2023-05-01 18:16:44
2023-05-01 13:03:22
2023-05-01 13:02:18
1529268
Hey !Friendica Support,
Did something recently happen to the Frio theme? I'm a blind screen reader user on venera.social. On around Friday or Saturday I was excited because a long-standing accessibility issue I'd had was fixed--specifically, tags like
Now, somehow, every header above posts is an
It's weird that this change just happened on a weekend. It may not have been a theme change either, so I'm wondering if anything on my end might have changed every post/comment heading in Frio to an
Thanks a bunch.
Did something recently happen to the Frio theme? I'm a blind screen reader user on venera.social. On around Friday or Saturday I was excited because a long-standing accessibility issue I'd had was fixed--specifically, tags like
<h4> and <h5> previously had ARIA applied to make them seem like level 1-2 headings and that created some additional speech verbosity where titles got double-presented as "heading level 4 heading level `1" for example.Now, somehow, every header above posts is an
<h5> Previously I could press 4 to quickly navigate between posts at heading level 4, then h if I wanted to jump to the next heading for comments. Now everything is at heading level 5, so I either read everything or navigate to the next post by context.It's weird that this change just happened on a weekend. It may not have been a theme change either, so I'm wondering if anything on my end might have changed every post/comment heading in Frio to an
h5? Would really like to undo whatever did this because it's going to make Friendica much harder to keep up with.Thanks a bunch.
utzer [Friendica]
•I think @Hypolite Petovan might be interested in this or can point us towards someone who can fix this.
Also I think the devs are always happy about insight from people using screen readers, maybe if you're interested in supporting the development in this direction you could get an account on https://squeet.me, which is run by @Michael Vogel and he usually runs the latest development release on that server, which means you'd get changes before a stable release and could report issues for screen readers before the release was done. Which I am sure would be very helpful.
Nolan Darilek
•It's interesting that I've essentially seen 3 themes in a short amount of time--last week the one I've used for a long time, briefly last weekend when the headings and ARIA representation agreed, and now. The second to third change seems like a major upgrade, but I thought we were running 23.04 last week. The hotfix didn't make a theme change, did it? Anyway, that's why I'm wondering if a settings change or something on my end may have done it, though I can't correlate a settings change with why the heading level might change.
Michael Vogel
•I had a quick look at the code. We do have "h4" and "h5" in the system but this hadn't been changed literally for years.
I think that we have to work at the headings, since it seems that this is done quite messy. For example it seems as if we aren't starting with "h1" at all. Where do you expect having headings? Only for each starting post or also for each comment? Or should the comment get a lower heading? So for example "h1" for the page header, "h2" for rhe subtitle. Then "h3" per starting point and "h4" per comment?
I also realized that we have got a problem when a post itself contains headings. What should we do then? Making them "h5" and "h6"?
Or should we possibly omit the headings at all and find some other way to make navigation possible?
Do you have got a github account? I would like to have it noted there, since I think that this here will lead to some more and longer work.
Thanks for pointing out the problems!
Nolan Darilek
•I'm ndarilek on GitHub. Happy to work with folks to figure things out. It's actually been a pretty decent experience for the year+ or so that I've used it. I think the headers are fine as is. I'd say my biggest issues are:
I think some of the permissions settings may be a bit tricky, but I don't do enough with those to comment meaningfully on them right now.
B... show more
I'm ndarilek on GitHub. Happy to work with folks to figure things out. It's actually been a pretty decent experience for the year+ or so that I've used it. I think the headers are fine as is. I'd say my biggest issues are:
I think some of the permissions settings may be a bit tricky, but I don't do enough with those to comment meaningfully on them right now.
But there do seem to be improvements in the new theme, including things that weren't buttons now presenting correctly, along with the previously-mentioned headings cleanup.
Thanks.
Michael Vogel
•Concerning content warnings: In the social media settings you find "Enable Content Warning". When you disable this, then content warnings are expanded automatically.
Nolan Darilek
•I'll open a few for these, though. I also just found that clicking a profile link in a comment header pops up a dropdown that I can't navigate, which would definitely challenge someone who didn't know they could just search for the link to view the local contact. I'll report those this week sometime.
Michael Vogel
•So take your time, report something when you want to. There is no pressure.
Nolan Darilek
•Sorry for the noise, but at least the bug fixed itself--the best kind of bug IMO. 😀