Skip to main content

AddOn rendertime broken?
Hi !Friendica Support
When I read the documentation on tuning Friendica performance, I read about the addon "rendertime", what should show a stack of times used renderng, db and so on.
When I add that using frio, nothing happens.
But when I enable "show callstack" in the addons configuration, my page goes all white w/o any chance to revert this on the UI.
Removing the hook it created from the "hook" table made my instance usable again.

Isn't that a little dangerous to propose addons in helpfiles, that react like this? Could it be, that this addon works only with older templates?

Am I right to assume the helpfiles are somewhat old and not very well maintained anymore? I think, "we" should go through the helpfiles some day and check, what is still up to date.
!Friendica Support
Grischa
Grischa  
•
P.S.: Or maybe we should check AddOns mentioned in the helpfiles if they are still supported. If I have time one evening I maybe will check what's the problem with rendertime.
Brian S.
Brian S.  
•
No trouble with the basic rendertime display on Frio using Friendica 2022.10 and version 2022.06 of the addon package. PHP 8.1.2, if it makes a difference. When I enable the call stack feature, I get a 500 error, and the following in Friendica's debug log:

Uncaught Exception TypeError: "Friendica\Util\Profiler::getRendertimeString(): Argument #1 ($limit) must be of type float, string given, called in /var/www/friendica/friendica/addon/rendertime/rendertime.php on line 89" at /var/www/friendica/friendica/src/Util/Profiler.php line 248

I managed to disable the addon thanks to browser history, but now can't turn it back on until I can see what's going on with the code. Thankfully, my instance is running smoothly at the moment, so I don't really need it.
#1
Hypolite Petovan
Hypolite Petovan  
•
@Grischa Yes, you are right to assume that help files are somewhat old and not very well maintained. It is a task that few people enjoy doing, and in such a small project as Friendica, it is hard to find consistent help in this regard.

I try to update the documentation of features I'm working on, but I don't always think about it. More to the point, the rendertime addon should work, I don't think the documentation is wrong about mentioning this add-on, it's more likely that we introduced a regression somewhere.
@Grischa

Friendica Support reshared this.

Grischa
Grischa  
•
This was no complaint at all btw! I am super thankfull for all the stuff that was done here. ❤
It was only a question. 😀
Hypolite Petovan
Hypolite Petovan  
•
@Grischa I didn't take it as a complaint, but I also wanted to set your expectations accurately!
@Grischa

Friendica Support reshared this.

⇧